Skip to content

[Provider Context] 2524 propose to add application via governance for a given provider #2551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
saraswatpuneet merged 69 commits into from
Aug 14, 2025
Merged

[Provider Context] 2524 propose to add application via governance for a given provider #2551

saraswatpuneet merged 69 commits into from
Aug 14, 2025

Conversation

@saraswatpuneet
Copy link
Collaborator

@saraswatpuneet saraswatpuneet commented Aug 13, 2025 •
edited
Loading

Goal

Details

With respect to provider context design doc, complete the following: Refer design doc

  • Add a new extrinsic propose_to_add_application that receives a ProviderRegistryEntry type payload from provider MSA
  • Ensure the origin is registered provider
  • Add a new state ProviderToApplicationRegistry douple map (ProviderId, ApplicationIndex) to store a new application once a goverance proposal is approved for application, where ApplicationIndex is monotically increasing number for each provider level application from 0..N
  • Move all the approves hashes from payload to ApprovedLogoHashes state
  • Benchmark new extrinsic
  • Add unit tests and e2e tests

Acceptance Criteria

  1. Ability to propose and add new applications
  2. ApprovedHashes successfully contains approved logo hashes from 1
  3. Tests emulating range of tests for adding and approving applications for providers
  4. Benchmarking and e2e tests

Closes #2524

Discussion

Checklist

  • Updated Pallet Readme?
  • Updated js/api-augment for Custom RPC APIs?
  • Design doc(s) updated?
  • Unit Tests added?
  • e2e Tests added?
  • Benchmarks added?
  • Spec version incremented?

saraswatpuneet and others added 30 commits August 1, 2025 13:08
@saraswatpuneet
base work moving payload around
24e3c9e
@saraswatpuneet
clean compile
54d12b8
@saraswatpuneet
update tests with new provider extrinsic structure
bc3a194
@saraswatpuneet
clean compile for make test and passing unit tests
0802303
@saraswatpuneet
fix existing e2e tests with new provider payload
234c33f
@saraswatpuneet
add provider test files and placeholder for e2e
5df8458
@saraswatpuneet
reject long name and used bounded types all the way
1be25ea
@saraswatpuneet @github-actions
Update weights
bea253e
@saraswatpuneet
check for cid version in payload
a31788d
@saraswatpuneet @github-actions
Update weights
82f8d8f
@saraswatpuneet
add checks for BCP compliant language code (basic versoion)
8b28d6d
@saraswatpuneet
define provider payload type for e2e tests
f4699c7
@saraswatpuneet @github-actions
Update weights
f0bfe8c
@saraswatpuneet
add negative e2e tests
519128d
@saraswatpuneet
add logos cid to ApprovedLogos state cid maps to logo bytes
0c7e4db
@saraswatpuneet @github-actions
Update weights
fca19af
@saraswatpuneet
set a getter for runtime query
9dd28e4
@saraswatpuneet
set placeholder for migration
848f957
@saraswatpuneet
some base workf for migration/try-runtime
eddd970
@saraswatpuneet
set some known providers for post upgrade tests
ed4f57c
@saraswatpuneet
first pass of migration of ProviderToRegistryEntry
ebecf35
@saraswatpuneet
try-runtime updates
50c5982
@saraswatpuneet
trigger ci on PR
bdde438
@saraswatpuneet
trigger ci
0c01901
@saraswatpuneet
clean build
b2fcde8
@saraswatpuneet
fix build
9dc4b8a
@saraswatpuneet
add some negative tests to cover the path
481d9dc
@saraswatpuneet
increase code coverage
6282615
@saraswatpuneet
increase code coverage
f577a69
@saraswatpuneet
update makefile , try-runtime needs --blocktime 6000
8b48351
@saraswatpuneet saraswatpuneet changed the title 2524 add application [Provider Context] 2524 propose to add application via governance for a given provider Aug 13, 2025
@github-actions github-actions bot added the metadata-changed Metadata has changed since the latest full release label Aug 13, 2025
@saraswatpuneet saraswatpuneet requested review from a team, JoeCap08055, aramikm, claireclark1, enddynayn, mattheworris and shannonwells and removed request for a team August 13, 2025 18:29
@github-actions github-actions bot added metadata-changed Metadata has changed since the latest full release and removed metadata-changed Metadata has changed since the latest full release labels Aug 13, 2025
saraswatpuneet
saraswatpuneet commented Aug 13, 2025
View reviewed changes
saraswatpuneet
saraswatpuneet commented Aug 13, 2025
View reviewed changes
saraswatpuneet
saraswatpuneet commented Aug 13, 2025
View reviewed changes
JoeCap08055
JoeCap08055 reviewed Aug 13, 2025
View reviewed changes
@github-actions github-actions bot added metadata-changed Metadata has changed since the latest full release and removed metadata-changed Metadata has changed since the latest full release labels Aug 13, 2025
aramikm
aramikm approved these changes Aug 13, 2025
View reviewed changes
Copy link
Collaborator

@aramikm aramikm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. 2 small comments

@github-actions github-actions bot removed the metadata-changed Metadata has changed since the latest full release label Aug 14, 2025
@github-actions github-actions bot added the metadata-changed Metadata has changed since the latest full release label Aug 14, 2025
@github-actions github-actions bot added metadata-changed Metadata has changed since the latest full release and removed metadata-changed Metadata has changed since the latest full release labels Aug 14, 2025
@saraswatpuneet saraswatpuneet merged commit 513f739 into feat/provider-context-development Aug 14, 2025
32 checks passed
@saraswatpuneet saraswatpuneet deleted the 2524_add_application branch August 14, 2025 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JoeCap08055 JoeCap08055 JoeCap08055 left review comments

@aramikm aramikm aramikm approved these changes

@wilwade wilwade Awaiting requested review from wilwade

@shannonwells shannonwells Awaiting requested review from shannonwells shannonwells was automatically assigned from frequency-chain/pr-reviewers

@mattheworris mattheworris Awaiting requested review from mattheworris mattheworris was automatically assigned from frequency-chain/pr-reviewers

@enddynayn enddynayn Awaiting requested review from enddynayn enddynayn was automatically assigned from frequency-chain/pr-reviewers

@claireclark1 claireclark1 Awaiting requested review from claireclark1 claireclark1 was automatically assigned from frequency-chain/pr-reviewers

Assignees

No one assigned

Labels

metadata-changed Metadata has changed since the latest full release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@saraswatpuneet @aramikm @JoeCap08055