Skip to content

Comments

Modify ETH keys to support pallet-revive#2336

Merged
aramikm merged 12 commits intomainfrom
eth_compatible_accounts
Apr 22, 2025
Merged

Modify ETH keys to support pallet-revive#2336
aramikm merged 12 commits intomainfrom
eth_compatible_accounts

Conversation

@aramikm
Copy link
Collaborator

@aramikm aramikm commented Apr 17, 2025

Goal

The goal of this PR is to modify accounts to be compatible with ETH keys used inn pallet-revive.

Closes #2289

Discussion

  • This is not a backwards compatible change but it doesn't appear that we have any accounts with previous formatting so it should be safe.

Checklist

  • Unit Tests added?
  • e2e modified
  • Spec version incremented?

@codecov
Copy link

codecov bot commented Apr 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
common/primitives/src/signatures.rs 72.40% <100.00%> (+13.46%) ⬆️
pallets/passkey/src/tests_v2.rs 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aramikm aramikm marked this pull request as ready for review April 18, 2025 23:09
@aramikm aramikm requested a review from wilwade as a code owner April 18, 2025 23:09
@github-actions github-actions bot added the metadata-changed Metadata has changed since the latest full release label Apr 18, 2025
@github-actions github-actions bot removed the metadata-changed Metadata has changed since the latest full release label Apr 21, 2025
Copy link
Collaborator

@wilwade wilwade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

  • Reviewed code
  • Reviewed Pallet Revive to confirm eeeeeeeeeeeeeeeeeeeeeeee

Copy link
Collaborator

@JoeCap08055 JoeCap08055 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comment/doc nits, but non-blocking. Approved.

@aramikm aramikm merged commit 6c09853 into main Apr 22, 2025
30 checks passed
@aramikm aramikm deleted the eth_compatible_accounts branch April 22, 2025 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Modify UnifiedSignature On-Chain for Revive Style ETH Account IDs

3 participants