Merged
Conversation
frenck
approved these changes
Nov 15, 2024
Owner
frenck
left a comment
frenck
left a comment
There was a problem hiding this comment.
Thanks, @wslaghekke 👍
../Frenck
frenck
added
the
bugfix
frenck
requested changes
Nov 15, 2024
Owner
frenck
left a comment
frenck
left a comment
There was a problem hiding this comment.
CI is failing. Did you actually test this? 😟
Contributor
Author
I did, but not with github, i used intellij, seems github doesnt like the trailing comma but intellij doenst mind, i will fix it |
frenck
approved these changes
Nov 15, 2024
Owner
frenck
left a comment
frenck
left a comment
There was a problem hiding this comment.
Thanks, @wslaghekke 👍
../Frenck
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When i tried starting the project using the provided devcontainer poetry failed because the built-in python version (3.10) was too old
Proposed Changes
Replace the base image with the updated python devcontainer base image that does contain the up-to date python version