fix 5.3 compatibility #197
Conversation
|
The fix works for me both with hg 5.3 on Windows and 5.2.2 on Arch Linux |
|
This worked for me (hg 5.3, Ubuntu 18.04, Python 2.7.17) |
|
FWIW this looks like a duplicate of #185 |
frej
left a comment
frej
left a comment
There was a problem hiding this comment.
As you and @chrisjbillington have noticed, this is the same fix as #185 and your explanation is indeed much better and includes the relevant information. The only problem is that the explanation is not in in the commit message, just in the PR comment. Please include the information in the git commit and I'll merge this fix.
While editing the commit message, please drop the "(status)" part in the subject, as it looks like a sub-system tag. Why not "Adapt to status becoming an object in Mercurial 5.3"?
frej
added
the
patch-exists
|
Commit message adapted |
Status has always been a tuple, but since 5.3, commit: https://www.mercurial-scm.org/repo/hg/rev/c5548b0b6847, it is an object. Therefore the __getitem__ of the tuple isn't available anymore. This fix is compatible with mercurial>=4.6, as the old status tuple still has the same properties.
Done |
frej
removed
the
patch-exists
|
Looks good. Thank you for your contribution. |
4 participants
fixes #196
Status has always been a tuple, but since 5.3, commit: https://www.mercurial-scm.org/repo/hg/rev/c5548b0b6847. is it an object. Therefore the
__getitem__of the tuple isn't available anymore.This fix is compatible with mercurial>=4.6, as the old status tuple still has the same properties.