autoupdater: execute sysupgrade test before network shutdown #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the autoupdater stops network prior starting the sysupgrade process. This has the issue of leaving the device in a state with stopped network in case the sysupgrade process fails, as execl does not spawn a subprocess but instead replaces the current process with another one, in our case the sysupgrade process. This commit modifies the autoupdater behavior in a way it starts sysupgrade in test mode prior stopping network. This way, common causes for failing the sysupgrade process can be detected in a remote-recoverable manner, most prominently a failed platform check / incompatible images. Signed-off-by: David Bauer <mail@david-bauer.net>
This was referenced Aug 18, 2021
Closed
|
Alternative PR #247 merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the autoupdater stops network prior starting the sysupgrade
process.
This has the issue of leaving the device in a state with stopped network
in case the sysupgrade process fails, as execl does not spawn a
subprocess but instead replaces the current process with another one, in
our case the sysupgrade process.
This commit modifies the autoupdater behavior in a way it starts
sysupgrade in test mode prior stopping network. This way, common causes
for failing the sysupgrade process can be detected in a
remote-recoverable manner, most prominently a failed platform check /
incompatible images.
Signed-off-by: David Bauer mail@david-bauer.net