Fix linting for initscripts #3471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Implify filename check - Check for ! in shebang - Check for either /bin/sh or anything ending with the word bash
Detect initscripts by their shebang line. SC2034 is ignored additionally for these scripts, to avoid needing to override it for setting START, USE_PROCD, ... in every single script.
github-actions
bot
added
3. topic: package
neocturne
added
the
2. status: waiting-on-review
rotanid
removed
the
2. status: waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We did accidentally not lint initscripts. Extend the lint script, and fix or disable warnings in initscripts.
All scripts have been tested except for radv-filterd, l3roamd and mmfd.