Shellcheck fixes + enabling of additional lints #3467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-wireguard The file appears to have been added to gluon-mesh-vpn-core by accident.
Warnings are either fixed properly, or disabled in a more fine-grained manner.
The only warnings that remain disabled globally for now handle the differences between POSIX sh and Busybox ash, as support for the latter was only added in shellcheck 0.10.
github-actions
bot
added
3. topic: package
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3450
I have done some light testing of the modified scripts on x86-64 qemu.
This is a reduced version of #3457 that doesn't change the wireguard netifd proto (and instead adds lint disables to the script for now), as I can't test it. #3457 will be rebased once this is merged.