gluon-web-model: resolve hang when submitting form with disabled element #2723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
3. topic: config-mode
mkg20001
force-pushed
the
warn-fix
branch
2 times, most recently
from
d08f5fe
to
fe9db40
Compare
neocturne
reviewed
Dec 13, 2022
Co-authored-by: Matthias Schiffer <mschiffer@universe-factory.net>
I was made aware of a bug when submitting the form while the element is disabled based on it's dependencies The fix was to inherit from AbstractValue instead of just node AbstractValue's AbstractValue:resolve_node_depends() in particular solves the issue, but it made more sense to just use the full base class
|
This looks promising. Thanks for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was made aware of a bug when submitting the form while the element is
disabled based on it's dependencies
(disable "enabled" in "private wifi", then save, while having mesh on wan enabled)
The fix was to inherit from AbstractValue instead of just node
AbstractValue's AbstractValue:resolve_node_depends() in particular
solves the issue, but it made more sense to just use the full base class
Also includes translations