Consider 'ITEM_PENDING_REVIEW' successful #67
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Publishing can return a status of ITEM_PENDING_REVIEW, which is a success condition of the publishing process.
|
Isn’t “ITEM_PENDING_REVIEW” the response for when there’s already a version in review? Because in that situation, any uploads will fail (with this message, presumably) |
|
The docs don’t give much explanation: https://developer.chrome.com/docs/webstore/webstore_api/items/publish/ |
|
Judging from other usage on GitHub, you appear to be correct: https://github.com/search?q=ITEM_PENDING_REVIEW&type=code I’ll fix the test issues separately, they require an update of XO in a separate PR |
|
I can confirm that there wasn't a version in review when I executed this code. Beyond that, I can answer no further. Thank you for your package and responsiveness! |
|
Released, thank you for the PR https://github.com/fregante/chrome-webstore-upload-cli/releases/tag/v2.2.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Publishing can return a status of ITEM_PENDING_REVIEW, which is a success response of the publishing process.