Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schema validator #50

Merged
merged 3 commits into from
Aug 16, 2017
Merged

Schema validator #50

merged 3 commits into from
Aug 16, 2017

Conversation

fedefernandez
Copy link
Contributor

Fixes #49

@codecov-io
Copy link

Codecov Report

Merging #50 into master will decrease coverage by 1.3%.
The diff coverage is 95.83%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #50      +/-   ##
==========================================
- Coverage   88.92%   87.62%   -1.31%     
==========================================
  Files          15       15              
  Lines         325      307      -18     
==========================================
- Hits          289      269      -20     
- Misses         36       38       +2
Impacted Files Coverage Δ
...n/scala/schema/validator/TroySchemaValidator.scala 100% <100%> (ø)
core/src/main/scala/schema/package.scala 100% <100%> (ø)
core/src/main/scala/schema/validator/package.scala 100% <100%> (ø)
...ain/scala/schema/provider/TroySchemaProvider.scala 83.33% <83.33%> (ø)
core/src/main/scala/config/model.scala 100% <0%> (+6.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fda39a7...9646946. Read the comment docs.

Copy link
Contributor

@raulraja raulraja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having a schema validation API for runtime verification based on Validated is awesome but we also need validation to happen in string interpolation at compile time.

@fedefernandez fedefernandez merged commit 9cfe86e into master Aug 16, 2017
@fedefernandez fedefernandez deleted the ff-issue-27-schema-validator branch August 16, 2017 05:42
@fedefernandez
Copy link
Contributor Author

Sure, I'll finish the story with #51 and then I'll continue with the interpolator (#45 & #19)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants