Deprecation warnings for strict keyword argument matching #563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@wasabigeek What do you think of this? |
wasabigeek
reviewed
Oct 14, 2022
floehopper
force-pushed
the
deprecation-warnings-for-strict-keyword-arguments
branch
from
061453c to
a8555d8
Compare
wasabigeek
approved these changes
Oct 14, 2022
floehopper
force-pushed
the
deprecation-warnings-for-strict-keyword-arguments
branch
2 times, most recently
from
776a696 to
40cec7a
Compare
floehopper
added a commit
that referenced
this pull request
Oct 15, 2022
This will generate a deprecation warning if Ruby >= v2.7,
Configuration#strict_keyword_argument_matching? is false, and a hash
matcher would stop matching if strict matching were enabled.
* Example 1:
mock = mock()
mock.expects(:method).with(:key => 42)
mock.method({ :key => 42 })
Expected keyword arguments (:key => 42), but received positional hash
({:key => 42}). These will stop matching when strict keyword argument
matching is enabled. See the documentation for
Mocha::Configuration#strict_keyword_argument_matching=.
* Example 2:
mock = mock()
mock.expects(:method).with(1, { :key => 42 }
mock.method(1, :key => 42)
Expected positional hash ({:key => 42}), but received keyword arguments
(:key => 42). These will stop matching when strict keyword argument
matching is enabled. See the documentation for
Mocha::Configuration#strict_keyword_argument_matching=.
See #563 for discussions about these changes.
Co-authored-by: Nicholas Koh <nicholas.koh@shopify.com>
floehopper
force-pushed
the
deprecation-warnings-for-strict-keyword-arguments
branch
from
40cec7a to
981c31b
Compare
floehopper
deleted the
deprecation-warnings-for-strict-keyword-arguments
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will generate a deprecation warning if Ruby >= v2.7,
Configuration#strict_keyword_argument_matching?isfalse, and a hash matcher would stop matching if strict matching were enabled. For example:Deprecation warning:
:key => 42 will stop matching {:key => 42} when strict keyword argument matching is enabled.Deprecation warning:
{:key => 42} will stop matching :key => 42 when strict keyword argument matching is enabled.