Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add flag to init #60

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jaimeph
Copy link
Contributor

@jaimeph jaimeph commented Nov 13, 2024

No description provided.

@jaimeph jaimeph linked an issue Nov 13, 2024 that may be closed by this pull request
@@ -11,31 +11,39 @@ import (
"github.com/freepik-company/gommitizen/internal/git"
)

const (
cmdInitBumpChangelog = "bump-changelog"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the official style and decisions documentacion for GO lang, constants should not base their names on their own values but in their role. So I propose change this to something like bumpChangelogFlagName or flagBumpChangelog

More info:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Auto changelog generation set in .version.json file
2 participants