Skip to content

Commit

Permalink
hostmem-file: make available memory-backend-file on POSIX-based hosts
Browse files Browse the repository at this point in the history
Before this change, memory-backend-file object is valid for Linux hosts
only because hostmem-file.c is compiled only on Linux hosts.
However, other POSIX-based hosts (such as macOS) can support
memory-backend-file object in the same way as on Linux hosts.
This patch makes hostmem-file.c and related functions to be compiled on
all POSIX-based hosts to make available memory-backend-file on them.

Signed-off-by: Hikaru Nishida <hikarupsp@gmail.com>
Message-Id: <20180924123205.29651-1-hikarupsp@gmail.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
  • Loading branch information
hikalium authored and bonzini committed Oct 2, 2018
1 parent 41d54dc commit d5dbde4
Show file tree
Hide file tree
Showing 5 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion backends/Makefile.objs
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ common-obj-$(CONFIG_POSIX) += rng-random.o
common-obj-$(CONFIG_TPM) += tpm.o

common-obj-y += hostmem.o hostmem-ram.o
common-obj-$(CONFIG_LINUX) += hostmem-file.o
common-obj-$(CONFIG_POSIX) += hostmem-file.o

common-obj-y += cryptodev.o
common-obj-y += cryptodev-builtin.o
Expand Down
2 changes: 1 addition & 1 deletion backends/hostmem-file.c
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ file_backend_memory_alloc(HostMemoryBackend *backend, Error **errp)
error_setg(errp, "mem-path property not set");
return;
}
#ifndef CONFIG_LINUX
#ifndef CONFIG_POSIX
error_setg(errp, "-mem-path not supported on this host");
#else
if (!host_memory_backend_mr_inited(backend)) {
Expand Down
4 changes: 2 additions & 2 deletions exec.c
Original file line number Diff line number Diff line change
Expand Up @@ -1734,7 +1734,7 @@ long qemu_getrampagesize(void)
}
#endif

#ifdef __linux__
#ifdef CONFIG_POSIX
static int64_t get_file_size(int fd)
{
int64_t size = lseek(fd, 0, SEEK_END);
Expand Down Expand Up @@ -2230,7 +2230,7 @@ static void ram_block_add(RAMBlock *new_block, Error **errp, bool shared)
}
}

#ifdef __linux__
#ifdef CONFIG_POSIX
RAMBlock *qemu_ram_alloc_from_fd(ram_addr_t size, MemoryRegion *mr,
uint32_t ram_flags, int fd,
Error **errp)
Expand Down
2 changes: 1 addition & 1 deletion include/exec/memory.h
Original file line number Diff line number Diff line change
Expand Up @@ -633,7 +633,7 @@ void memory_region_init_resizeable_ram(MemoryRegion *mr,
uint64_t length,
void *host),
Error **errp);
#ifdef __linux__
#ifdef CONFIG_POSIX

/**
* memory_region_init_ram_from_file: Initialize RAM memory region with a
Expand Down
2 changes: 1 addition & 1 deletion memory.c
Original file line number Diff line number Diff line change
Expand Up @@ -1557,7 +1557,7 @@ void memory_region_init_resizeable_ram(MemoryRegion *mr,
}
}

#ifdef __linux__
#ifdef CONFIG_POSIX
void memory_region_init_ram_from_file(MemoryRegion *mr,
struct Object *owner,
const char *name,
Expand Down

0 comments on commit d5dbde4

Please sign in to comment.