Fix overflow in strtod mantissa read when sizeof(int) is 2 #136
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mantissa read loop in strtod reads 18 digits using two ints to convert nine digits each. When sizeof(int) is 2 the conversion value overflows. To fix this the types of frac1 and frac2 have been changed to long.
Example:
printf("val f: %f\n", strtof("0.123456789012345678",NULL));
printf("val d: %f\n", strtod("0.123456789012345678",NULL));
Without fix:
val f: 0.000249
val d: 0.000249
With fix:
val f: 0.123457
val d: 0.123457