ipauser: Support for External IdP attributes. #1055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjeffman
force-pushed
the
ipauser_idp_attrs
branch
2 times, most recently
from
fc622aa
to
a8a9700
Compare
rjeffman
changed the title
rjeffman
force-pushed
the
ipauser_idp_attrs
branch
from
a8a9700
to
425b8a3
Compare
|
There's still an issue with "timing" on the tests, as the command to create the IDP entry is not working when executed inside the testing container, but always succeed in a clean CentOS 9 Stream VM. |
rjeffman
force-pushed
the
ipauser_idp_attrs
branch
from
425b8a3
to
4ca315c
Compare
|
It was not timing after all... The |
rjeffman
force-pushed
the
ipauser_idp_attrs
branch
4 times, most recently
from
665630c
to
8d678e1
Compare
|
idp and idp_user_id parameters are not in the spec anymore. |
rjeffman
force-pushed
the
ipauser_idp_attrs
branch
from
8d678e1
to
722ebba
Compare
Add support for 'idp' and 'idp_user_id' to ipauser plugin. FreeIPA 4.10.0 is required for both attributes.
rjeffman
force-pushed
the
ipauser_idp_attrs
branch
from
722ebba
to
6fa8223
Compare
|
@t-woerner PR is ready for review again. |
varunmylaraiah
approved these changes
Jul 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for 'idp' and 'idp_user_id' to ipauser plugin.
FreeIPA 4.10.0 is required for both attributes.