Fix: improve tuf spec conformance and match functionality to tuf-js implementation #13
+95
−60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
sachaservan
commented
Nov 28, 2025
sachaservan
commented
- add length verification for metadata files (snapshot, targets) and target files per TUF spec 5.5.2/5.6.2
- verify all provided hash algorithms, not just sha256 (fixes an open TODO)
- validate signature threshold >= 1 to match tuf-js verifications in Role
- validate required top-level roles exist (root, timestamp, snapshot, targets) to match verifications in tuf-js Role
- Document keyid verification deviation that matches tuf-js behavior
Add validation in checkSignatures to reject threshold < 1, matching tuf-js behavior in Role constructor.
Add validation in loadRoot to: - Ensure all required top-level roles exist (root, timestamp, snapshot, targets) - Reject roles with duplicate keyids Matches tuf-js validation in Root constructor and Role constructor.
lsd-cat
approved these changes
Nov 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.