Improve testing of static assets in Debian packaging #5644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add more complete testing of packaging of static assets. Simplify conftest, eliminate testutils in builder-xenial scenario. In builder-xenial/test_securedrop_deb_package, eliminate some host calls and inefficient parameterization, to speed things up.
rmol
force-pushed
the
improve-asset-tests
branch
from
93c76e1
to
eaa013a
Compare
zenmonkeykstop
approved these changes
Nov 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready for review
Description of Changes
Add more complete testing of packaging of static assets.
Simplify conftest, eliminate testutils in builder-xenial scenario.
In builder-xenial/test_securedrop_deb_package, eliminate some host calls and inefficient parameterization, to speed things up.
Fixes #5643.
Testing
develop.securedrop/.rsync-filter:make build-debs-- the missing icons should cause no errors.git checkout -b improve-asset-tests origin/improve-asset-testsmake build-debs-- the missing icons should cause test errors.Checklist
If you made changes to the server application code:
make lint) and tests (make test) pass in the development containerIf you made non-trivial code changes:
Choose one of the following: