Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update builder image #5054

Merged
merged 1 commit into from
Dec 3, 2019
Merged

Update builder image #5054

merged 1 commit into from
Dec 3, 2019

Conversation

emkll
Copy link
Contributor

@emkll emkll commented Dec 3, 2019 •
edited
Loading

Status

Ready for review

Description of Changes

Towards #5004

Updated the builder image based on the docs in the Docker build maintenance guide

Testing

  • CI is running the deb-tests job
  • CI is passing

Deployment

This change is dev-only

Checklist

If you made non-trivial code changes:

  • I have written a test plan and validated it for this PR

@emkll
Update builder hash
31ec533 
Builder image needed updates
@emkll emkll added this to the 1.2.0 milestone Dec 3, 2019
redshiftzero
redshiftzero approved these changes Dec 3, 2019
View reviewed changes
Copy link
Contributor

@redshiftzero redshiftzero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ci passing including deb tests job so merging

@redshiftzero redshiftzero merged commit bfeffd0 into develop Dec 3, 2019
@redshiftzero redshiftzero deleted the update-builder-20191203 branch December 3, 2019 15:46
@emkll emkll mentioned this pull request Dec 3, 2019
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@redshiftzero redshiftzero redshiftzero approved these changes

@conorsch conorsch Awaiting requested review from conorsch

@kushaldas kushaldas Awaiting requested review from kushaldas

@zenmonkeykstop zenmonkeykstop Awaiting requested review from zenmonkeykstop

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@emkll @redshiftzero