Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade boxes for SecureDrop 0.14.0 #4617

Merged
merged 1 commit into from
Jul 15, 2019
Merged

Conversation

emkll
Copy link
Contributor

@emkll emkll commented Jul 11, 2019

Status

Work in progress : Must be rebased once #4616 is merged due to version bump required for makefile targets to work

Description of Changes

Towards #4550 .

Testing

On this branch:

  • make build-debs
  • make upgrade-start
  • Boxes come up and source interface shows version 0.14.0
  • make upgrade-test-local
  • Upgrade is successful and source interface shows version 1.0.0~rc1

Deployment

Dev only

Checklist

If you made changes to the server application code:

  • Linting (make lint) and tests (make -C securedrop test) pass in the development container

If you made changes to securedrop-admin:

  • Linting and tests (make -C admin test) pass in the admin development container

If you made changes to the system configuration:

If you made non-trivial code changes:

  • I have written a test plan and validated it for this PR

If you made changes to documentation:

  • Doc linting (make docs-lint) passed locally

@redshiftzero redshiftzero mentioned this pull request Jul 11, 2019
19 tasks
@zenmonkeykstop
Copy link
Contributor

Rebased after merging #4616.

@emkll emkll marked this pull request as ready for review July 15, 2019 14:28
@zenmonkeykstop
Copy link
Contributor

Tested as per instructions:

  • Boxes come up and source interface shows version 0.14.0

  • Upgrade is successful and source interface shows version 1.0.0~rc1

Copy link
Contributor

@zenmonkeykstop zenmonkeykstop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM based on upgrade test and diff review.

@zenmonkeykstop zenmonkeykstop merged commit 5d06e4d into develop Jul 15, 2019
@emkll emkll deleted the upgrade-boxes-0.14.0 branch October 8, 2019 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants