Replace "Cloud" upload icon with more neutral one #4548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eloquence
requested review from
conorsch,
emkll,
heartsucker,
kushaldas,
msheiny and
redshiftzero
as code owners
eloquence
commented
Jun 25, 2019
| @@ -267,7 +267,7 @@ | |||
| /var/www/securedrop/static/i/font-awesome/trash-black.png r, | |||
| /var/www/securedrop/static/i/font-awesome/black/guard.svg r, | |||
| /var/www/securedrop/static/i/font-awesome/white/guard.svg r, | |||
| /var/www/securedrop/static/i/font-awesome/white/exclamation-circle.svg r, | |||
| /var/www/securedrop/static/i/font-awesome/white/exclamation-circle.svg r, | |||
There was a problem hiding this comment.
(My editor cleans up trailing wihtespace by default.)
eloquence
force-pushed
the
upload-icon-redux
branch
from
6a49d6f
to
4cee096
Compare
Adds rendering rule for the icon to accomplish two things: - give the icon room to breathe - force crisp rendering, to render large source image cleanly at smaller size (the source PNG is a bit larger than the default size to accommodate zooming) The crisp rendering rule may make sense as a generic rule at a later point, but so far this seems to be the best candidate for using it. The new icon was designed by Nina Alter (@ninavizz) and is not derived from FontAwesome, hence not in the font-awesome directory. Resolves #4535
eloquence
force-pushed
the
upload-icon-redux
branch
from
4cee096
to
e69f9fb
Compare
Codecov Report
@@ Coverage Diff @@
## develop #4548 +/- ##
===========================================
+ Coverage 80.42% 82.53% +2.11%
===========================================
Files 45 45
Lines 3121 3121
Branches 339 339
===========================================
+ Hits 2510 2576 +66
+ Misses 520 458 -62
+ Partials 91 87 -4
Continue to review full report at Codecov.
|
zenmonkeykstop
approved these changes
Jun 25, 2019
There was a problem hiding this comment.
Tested in Qubes staging environment:
- confirmed icons match those in test plan, and zooming into page doesn't affect fidelity
- confirmed no errors triggered in
/var/log/apache2/source-error.log,/var/log/kern.log,/var/log/syslogwhen icons are loaded.
LGTM once CI passes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds rendering rule for the icon to accomplish two things:
The crisp rendering rule may make sense as a generic rule at a later point, but so far this seems to be the best candidate for using it.
The new icon was designed by Nina Alter (@ninavizz) and is not derived from FontAwesome, hence not in the
font-awesomedirectory.Resolves #4535
Status
Ready for review
Test plan
The screens should look as follows:
Index page (default state):
Index page (hover state):
Upload screen:
