replace pycryptodome with pyca/cryptography 2.0.3 #3458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Latest pyca/cryptography requires setuptools>18.5, which we do not have on prod installs. In order to make this transition in the next minor release however, we can temporarily pin to a slightly older version of pyca/cryptography, such that we can install it using the version of setuptools that we have. For the Docker dev env, we need libffi-dev installed to pip install cryptography.
ghost
added
|
On the build on 117acb664588c8664f23ee0101279e35bf601279, there is a test failure on |
redshiftzero
force-pushed
the
cryptography-2.0.3
branch
from
81f029d
to
7f636da
Compare
Codecov Report
@@ Coverage Diff @@
## develop #3458 +/- ##
===========================================
+ Coverage 85.87% 85.93% +0.05%
===========================================
Files 34 34
Lines 2167 2175 +8
Branches 241 241
===========================================
+ Hits 1861 1869 +8
Misses 250 250
Partials 56 56
Continue to review full report at Codecov.
|
4 tasks
redshiftzero
changed the title
|
Hey @emkll, take a look at this one when you get a chance 😇 |
emkll
approved these changes
May 24, 2018
There was a problem hiding this comment.
Changes look good to me, thanks @reaperhulk and @redshiftzero !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready for review
Description of Changes
Fixes #3399, remix of #3400
See #3441 for why cryptography 2.0.3 is what we'll need to install in 0.8.0
Testing
The integration tests and the secure tempfile unit tests here do test this functionality.
In addition, one can manually test by submitting a file that is greater than 512KB and ensuring that you can successfully decrypt it.
Deployment
It will install without issue on existing and new installs
Checklist
If you made changes to the server application code:
make ci-lint) and tests (make -C securedrop test) pass in the development container