Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove "informational" status of HTML validation once HTML is expected to validate :-) #6078

Open
cfm opened this issue Aug 25, 2021 · 1 comment

Comments

@cfm
Copy link
Member

cfm commented Aug 25, 2021

Description

This is a reminder to remove the "informational" status of the HTML validation introduced in #6072...once HTML can be expected to validate on develop and we want to hold contributors' pull requests to that standard.

# Once HTML can be expected to validate, remove "|| true" and
# "informational" status---in other words, fail if validation fails!
- run:
name: Validate HTML (informational)
command: make validate-test-html || true

@cfm
Copy link
Member Author

cfm commented Dec 21, 2021

We should revisit this question especially in light of html5validator's dependency on a JDK and https://github.com/validator/validator. The latter in turn depends on Log4j, albeit a version prior to those vulnerable to the Log4shell exploits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant