Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cryptography dependency #5898

Closed
eloquence opened this issue Apr 13, 2021 · 2 comments · Fixed by #5964
Closed

Update cryptography dependency #5898

eloquence opened this issue Apr 13, 2021 · 2 comments · Fixed by #5964
Assignees
Milestone

Comments

@eloquence
Copy link
Member

The cryptography library is currently pinned at version 3.2.1, because 3.3 dropped Python 3.5 support, which is the version of Python included with Ubuntu 16.04.

After the full removal of Xenial support (#5725), we should be in a good position to update the cryptography library as part of the SecureDrop 2.0.0 release. We can consider:

  • version 3.3.2, which as of this writing is the last release with security fixes, and which was released prior to the inclusion of Rust code
  • the latest stable version at the time of release, which will introduce the Rust build requirement.
@eloquence eloquence added this to the 2.0.0 milestone Apr 13, 2021
@eloquence eloquence modified the milestones: 2.0.0, 1.9.0 Apr 15, 2021
@eloquence eloquence removed the blocked label May 3, 2021
@eloquence
Copy link
Member Author

With #5911 merged, this should now be unblocked.

@kushaldas
Copy link
Contributor

For the 2.0.0 release, I suggest to move to the 3.3.2 as we can easily build it from the sources, and then in the next release we can change the build process to use the prebuilt wheels from our workflow/git repository.

@kushaldas kushaldas self-assigned this May 25, 2021
kushaldas added a commit that referenced this issue May 27, 2021
This commit brings in the rust compiler toolchain during the package
build and also updates the cryptography package to the latest 3.4.7
kushaldas added a commit that referenced this issue Jun 1, 2021
Updates the cryptography package to the latest 3.4.7
zenmonkeykstop pushed a commit that referenced this issue Jun 1, 2021
Updates the cryptography package to the latest 3.4.7
@rmol rmol closed this as completed in #5964 Jun 1, 2021
rmol added a commit that referenced this issue Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants