Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove NoScript workaround instructions from Source Interface #4160

Closed
eloquence opened this issue Feb 20, 2019 · 6 comments · Fixed by #4319
Closed

Remove NoScript workaround instructions from Source Interface #4160

eloquence opened this issue Feb 20, 2019 · 6 comments · Fixed by #4319
Milestone
0.12.2

Comments

@eloquence
Copy link
Member

In #4153, we introduced instructions to the Source Interface for working around a NoScript/Firefox issue which causes some uploads to fail. The upstream NoScript issue (closed as a Firefox issue is being pinpointed as the root cause) is hackademix/noscript#64; the best candidate for the underlying Firefox issue appears to be: https://bugzilla.mozilla.org/show_bug.cgi?id=1506562

These instructions are cumbersome and the upstream issue will hopefully be resolved ASAP. We'll need to continue to monitor upstream and remove the instructions once a fix has landed in the latest releases of Tor Browser Bundle & Tails.
@eloquence eloquence added this to the Long Term Product Backlog milestone Feb 20, 2019
@eloquence
Copy link
Member Author

I've filed https://bugzilla.mozilla.org/show_bug.cgi?id=1532530 for additional follow-up.

@ninavizz
Copy link
Member

ninavizz commented Mar 5, 2019

Is this Issue more of a "to do" for once the issue has been fixed on the Mozilla/NS end?

@eloquence
Copy link
Member Author

Yes, exactly. Hence the "blocked" label, which I'll remove once the upstream issue is fixed and the fix can be expected to reach most Tor browser users by the time of the next SecureDrop release milestone.

@eloquence
Copy link
Member Author

See tbb-dev thread Firefox/NoScript bug with major downstream effects for discussion with Tor browser developers, as well.

@eloquence
Copy link
Member Author

Upstream Tor browser issue proposing to change the default, & discussion: https://trac.torproject.org/projects/tor/ticket/29733

@eloquence eloquence removed the blocked label Apr 2, 2019
@eloquence
Copy link
Member Author

The NoScript fix is included in Tor 8.0.8 (released March 21) so we should be able to revert the warning potentially for 0.12.2, pending QA:

https://blog.torproject.org/new-release-tor-browser-808

eloquence added a commit that referenced this issue Apr 2, 2019
@eloquence
Revert "Add instructions for working around NoScript XSS upload problem"
9fbc098 
Resolves #4160

This reverts commit b355308.
@eloquence eloquence mentioned this issue Apr 3, 2019
Merged
1 task
eloquence added a commit that referenced this issue Apr 4, 2019
@eloquence
Revert "Add instructions for working around NoScript XSS upload problem"
7f0586b 
Resolves #4160

This reverts commit b355308.
emkll pushed a commit that referenced this issue Apr 17, 2019
@eloquence @emkll
Revert "Add instructions for working around NoScript XSS upload problem"
646ea0f 
Resolves #4160

This reverts commit b355308.

(cherry picked from commit 7f0586b)
emkll pushed a commit that referenced this issue Apr 17, 2019
@eloquence @emkll
Revert "Add instructions for working around NoScript XSS upload problem"
942cdbe 
Resolves #4160

This reverts commit b355308.

(cherry picked from commit 7f0586b)
kushaldas pushed a commit that referenced this issue Sep 25, 2019
@eloquence @kushaldas
Revert "Add instructions for working around NoScript XSS upload problem"
c1722e6 
Resolves #4160

This reverts commit b355308.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.12.2
Development

Successfully merging a pull request may close this issue.

Revert "Add instructions for working around NoScript XSS upload problem" freedomofpress/securedrop
2 participants
@eloquence @ninavizz