dont use hasattr for checking presence of attrs

freedomofpress · Apr 18, 2019 · c0a0ccd · c0a0ccd
1 parent 7a9ed83
commit c0a0ccd
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/securedrop/worker.py b/securedrop/worker.py
@@ -22,7 +22,10 @@ def init_app(self, app):
         self.__app = app
         self.__app.config.setdefault('RQ_WORKER_NAME', 'default')
 
-        if not hasattr(self.__app, 'extensions'):
+        try:
+            # check for presence of existing extension dict
+            self.__app.extensions
+        except AttributeError:
             self.__app.extensions = {}
 
         queue_name = self.__app.config['RQ_WORKER_NAME']