Verify PGP key embedded in .sources files are correct #1183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's kind of hard to manually test the PGP key inside apt's .sources files are the ones we intended, so write a test to do it. This is copied from the one I wrote in securedrop-client, and adds coverage for the apt-test sources file. This isn't a launcher test, but it needs to have external dependencies installed, so this is the best place for it now until we have unit tests for the rest of the provisioning code.
legoktm
force-pushed
the
test-sources
branch
from
3ac7b48
to
632fe81
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready for review
Description of Changes
It's kind of hard to manually test the PGP key inside apt's .sources files are the ones we intended, so write a test to do it. This is copied from the one I wrote in securedrop-client, and adds coverage for the apt-test sources file.
This isn't a launcher test, but it needs to have external dependencies installed, so this is the best place for it now until we have unit tests for the rest of the provisioning code.
Testing
Deployment
Any special considerations for deployment? n/a