Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test that apt interprets our .sources files correctly #1093

Merged
merged 1 commit into from
Oct 1, 2024
Merged

Conversation

legoktm
Copy link
Member

@legoktm legoktm commented Jun 18, 2024

Status

Ready for review

Description of Changes

Run apt-get indextargets to verify that our .sources files are valid and apt is able to properly interpret them.

I didn't implement actually running apt to check that we can download files because that happens during provisioning already.

Testing

  • CI passes

Deployment

Any special considerations for deployment? n/a, test only

Checklist

  • All tests (make test) pass in dom0

deeplow
deeplow previously approved these changes Jun 24, 2024
Copy link
Contributor

@deeplow deeplow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested locally on a dev environment and did a visual review.

tests/test_vms_platform.py Outdated Show resolved Hide resolved
@cfm
Copy link
Member

cfm commented Sep 10, 2024

This is now conflicted. I'll be happy to re-review once that's resolved.

Run `apt-get indextargets` to verify that our .sources files are valid
and apt is able to properly interpret them.

I didn't implement actually running apt to check that we can download
files because that happens during provisioning already.
@legoktm
Copy link
Member Author

legoktm commented Sep 23, 2024

Rebased.

Copy link
Member

@cfm cfm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @legoktm. Since I'm largely deferring to @deeplow's previous review, I hadn't noticed earlier your anti-superstition change here: if what we're testing is a property of templates, just test the templates, not every VM that necesarily derives that property from its template. Nice.

@cfm cfm added this pull request to the merge queue Oct 1, 2024
Merged via the queue into main with commit 1bb836d Oct 1, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants