This repository was archived by the owner on Jan 5, 2024. It is now read-only.
ci: ensure that requirements files are in sync #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this guards against a scenario discovered in: #46 (comment) wherein a contributor would update build-requirements.txt but not requirements.txt
kushaldas
approved these changes
Oct 31, 2019
redshiftzero
added a commit
to freedomofpress/securedrop-client
that referenced
this pull request
Oct 31, 2019
this ensures that diffs that update build-requirements.txt without updating requirements.txt fail CI
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR guards against a scenario discovered here wherein a contributor would update
build-requirements.txtbut notrequirements.txtand our build would pass in CI. We want to ensure that these requirements files are kept in sync and prevent merge of diffs that update one but not the other.To confirm this change works as expected, you can inspect: