Drop TLD from URL shortcut, add theintercept.com #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update README to specify --require-hashes and --no-deps when pip installing to avoid downloading transive dependencies without version/hash pinning
- https://news.com should have SecureDrop URL news.securedrop.tor.onion instead of news.com.securedrop.onion - org_url + securedrop_tld = securedrop_redirect_url - Also remove trailing newline from onboarded org url string
And preserve old lucyparsonslab.com
This is the intermediate public key generated by make test-key
|
This looks great - all checks in the test plan LGTM. Sign away! |
|
This is now ready for final review. I have deleted the old rulesets and their associated signatures. I assume they are used only for roll back and auditing purposes. Since we are preserving these it git history, it will help keep this repo cleaner at the cost of manual deletion work. |
redshiftzero
approved these changes
Apr 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2
Per #2 (comment) , updates the naming scheme and adds The Intercept to the ruleset.
Test plan
about:addonsin the URL barrelease-pubkey.jwk)lucyparsonslabs.com.securedrop.tor.onionandlucyparsonslabs.securedrop.tor.onionshould redirect you tohttp://qn4qfeeslglmwxgb.onion/theintercept.securedrop.tor.onionshould redirect you tohttp://xpxduj55x2j27l2qytu2tcetykyfxbjbafin3x4i3ywddzphkbrd3jyd.onion/