Modify v3 migration instructions to emphasize concurrent upgrade path #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rocodes
force-pushed
the
v3-migration-clarify
branch
from
0b837e5
to
714761d
Compare
zenmonkeykstop
previously requested changes
Oct 23, 2020
| - If your instance uses HTTPS, you will need to provision a new certificate for | ||
| the v3 *Source Interface* address - this will need to be done `after` the new | ||
| address has been generated. | ||
|
|
||
| .. note:: If your certificate provisioning process requires validation of the |
There was a problem hiding this comment.
Again, this is overly simple IMO, we should be upfront with folks about why they need to contact us.
There was a problem hiding this comment.
I just switched the order of these sentences, nothing was removed. Do you still feel like it's too simplistic? If so I can revert, but I think the note/callout reads clearer this way.
rocodes
force-pushed
the
v3-migration-clarify
branch
from
714761d
to
71d4739
Compare
eloquence
reviewed
Oct 29, 2020
eloquence
reviewed
Oct 29, 2020
eloquence
reviewed
Oct 29, 2020
eloquence
reviewed
Oct 29, 2020
|
Thanks @rocodes, I quite like the improved organization of the procedural steps; once comments are resolved, I think this is good to go. |
rocodes
force-pushed
the
v3-migration-clarify
branch
2 times, most recently
from
0a6c02f
to
61fa02a
Compare
rocodes
force-pushed
the
v3-migration-clarify
branch
from
61fa02a
to
0ff5cbd
Compare
eloquence
approved these changes
Nov 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready for review
Description of Changes
Testing
Release
Checklist (Optional)
make docs-lint) passed locallymake docs-linkcheck) passedmake docs) docs at http://localhost:8000