app: use ServerConnectionError from SDK 0.0.13 (resolves failed sync causing AuthError, and KeyError during a failed download) #784
+70
−50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
redshiftzero
force-pushed
the
use-sdk-serverconnectionerror
branch
from
74889ff
to
25aeb2c
Compare
|
I'm no longer getting kicked out on sync on this branch, in Qubes. 🎉 |
Merged
5 tasks
these two exceptions should behave the same from the perspective of the client. At some later point, we may want to customize behavior (e.g. since the ServerConnectionError will be raised much faster than a RequestTimeoutError).
redshiftzero
changed the title
redshiftzero
requested review from
sssoleileraaa and
kushaldas
as code owners
sssoleileraaa
approved these changes
Feb 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
⚠️ First merge freedomofpress/securedrop-builder#143 and then rerun the build job below (it will fail until the required dependency is deployed to the pip mirror, which will be upon merge of that PR) ⚠️ Checklist
If these changes modify code paths involving cryptography, the opening of files in VMs or network (via the RPC service) traffic, Qubes testing in the staging environment is required. For fine tuning of the graphical user interface, testing in any environment in Qubes is required. Please check as applicable:
If these changes add or remove files other than client code, packaging logic (e.g., the AppArmor profile) may need to be updated. Please check as applicable: