Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

app: add pending reply status, persist replies in the database #578

Merged
merged 12 commits into from
Nov 7, 2019
Merged

app: add pending reply status, persist replies in the database #578

merged 12 commits into from
Nov 7, 2019

Commits on Oct 31, 2019

  1. app: persisting replies in the database if pending, failed

    @redshiftzero
    redshiftzero committed Oct 31, 2019
    Configuration menu
    Copy the full SHA
    196c969 View commit details
    Browse the repository at this point in the history

  2. app: add pending reply before adding to send queue

    @redshiftzero
    redshiftzero committed Oct 31, 2019
    Configuration menu
    Copy the full SHA
    c281524 View commit details
    Browse the repository at this point in the history

  3. app: failed/pending replies don't get deleted by the sync action

    @redshiftzero
    redshiftzero committed Oct 31, 2019
    Configuration menu
    Copy the full SHA
    9958697 View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2019

  1. app: create separate object for draft/pending/failed replies 

    during the sync, we don't attempt to delete draft replies in
the source.collection they aren't stored on disk, but will get
deleted by the cascade delete when the source is deleted.

however we also ensure that duplicate drafts are cleaned up on sync
to handle the scenario where a ReplySendJob "fails" but the reply
_was_ actually saved properly on the server.
    @redshiftzero
    redshiftzero committed Nov 4, 2019
    Configuration menu
    Copy the full SHA
    1325068 View commit details
    Browse the repository at this point in the history

  2. test: update tests for pending/failed/draft replies

    @redshiftzero
    redshiftzero committed Nov 4, 2019
    Configuration menu
    Copy the full SHA
    935de8a View commit details
    Browse the repository at this point in the history

  3. test: ensure sync does not delete (non-existent) DraftReply files

    @redshiftzero
    redshiftzero committed Nov 4, 2019
    Configuration menu
    Copy the full SHA
    73e13b7 View commit details
    Browse the repository at this point in the history

  4. app: make pending color bar blue (addresses UX feedback)

    @redshiftzero
    redshiftzero committed Nov 4, 2019
    Configuration menu
    Copy the full SHA
    dc878cd View commit details
    Browse the repository at this point in the history

  5. test: add coverage for draft cleanup during sync

    @redshiftzero
    redshiftzero committed Nov 4, 2019
    Configuration menu
    Copy the full SHA
    c3fb666 View commit details
    Browse the repository at this point in the history

  6. test: additional coverage for expected ordering of drafts/replies

    @redshiftzero
    redshiftzero committed Nov 4, 2019
    Configuration menu
    Copy the full SHA
    4880707 View commit details
    Browse the repository at this point in the history

  7. login/out should fail any pending replies

    @redshiftzero
    redshiftzero committed Nov 4, 2019
    Configuration menu
    Copy the full SHA
    03c116b View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2019

  1. app, test: run draft re-ordering after sync in addition to reply send 

    if a user sends multiple replies A, B, C, the order should always be
A, B, C, even if:

* A fails
* B sends successfully
* C is pending

we ensure that once a reply sends successfully - or we find that
a reply _did_ send but we have it marked as failed as we never got
the response (h/t @creviera for testing this case) - that we ensure
that C appears after B. this is done by updating the file_counter.
    @redshiftzero
    redshiftzero committed Nov 5, 2019
    Configuration menu
    Copy the full SHA
    95db9b4 View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2019

  1. app: explain the client-side re-ordering in a docstring

    @redshiftzero
    redshiftzero committed Nov 6, 2019
    Configuration menu
    Copy the full SHA
    44c4394 View commit details
    Browse the repository at this point in the history