gui: center all popup windows #487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The effect of removing the parent to QMessageBox means that the box gets rendered in the center of the screen (controlled by the window manager) instead of at the center of the parent. Be aware that by using QMessageBox.question we were not allowing deletion of the parent to delete the child: https://doc.qt.io/qt-5/qmessagebox.html#question
kushaldas
approved these changes
Jul 23, 2019
There was a problem hiding this comment.
Tested on my system, approved 🌈
- confirm LoginDialog starts in center of screen when app first launches
- confirm when in offline mode, clicking "sign in" in the left sidebar starts the LoginDialog in the center of the screen
- confirm that the source deletion dialog launches in the center of the screen when clicked via the "..." button
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #322
Test Plan
Checklist
If these changes modify code paths involving cryptography, the opening of files in VMs, network (via the RPC service) traffic, or fine tuning of the graphical user interface, Qubes testing is required. Please check as applicable: