-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ensure safe perms for svs.sqlite and sync_flag #1256
Conversation
8b7e3ab
to
f3d2732
Compare
f3d2732
to
b3f16cc
Compare
rebased on latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes here work well, but it's important to note that it will not update existing svs.sqlite
and sync_flag
files: These changes will only work if/when those files are created by the client. I think this is fine to merge as-is.
b3f16cc
to
38a1d2e
Compare
@emkll - to address your feedback, i updated the client to fix insecure perms when it starts. follow the test plan, but instead of deleting |
a196e85
to
00a9c08
Compare
Signed-off-by: Allie Crevier <allie@freedom.press>
00a9c08
to
8019c11
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @creviera for the changes, went through another round of testing, looks good to me!
Description
Fixes #1232
Test Plan
securedrop-client