Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust clickable target area in auth widget and style sign-out menu #285

Closed
1 of 3 tasks
sssoleileraaa opened this issue Mar 27, 2019 · 6 comments
Closed
1 of 3 tasks
Labels
help wanted Extra attention is needed

Comments

@sssoleileraaa
Copy link
Contributor

sssoleileraaa commented Mar 27, 2019

Description

Remaining work for auth widget from #264

Once specific colors are decided on:

  • Make journalist username's font color a lighter during hover-over action
  • Change color of highlighted menu option

Auth widget selected:
auth-widget-selected

Auth widget clicked:
auth-widget-clicked

@sssoleileraaa
Copy link
Contributor Author

Try to use these colors when creating placeholders for final colors:

https://app.zeplin.io/project/5c807ea562f734bd2756b243/screen/5c9d42bec4045605c4a2142c

@ninavizz
Copy link
Member

ninavizz commented Apr 1, 2019

Note: dotted-pink line and yellow highlight, were part of my annotations—not part of the intended design. 😄

@sssoleileraaa
Copy link
Contributor Author

This task can be marked as done once PR #293 gets merged:

  • Make clicking on journalist's name trigger the sign-out drop-down menu

@eloquence
Copy link
Member

I've updated the issue description per Nina's comment, and transformed the tasks into a checklist.

Ensuring that the clickable area matches the spec (and having a mouse cursor affordance for same - #415) is IMO especially important for usability. Right now, clicking the initials does not open the drop down menu.

eloquence added a commit that referenced this issue Jan 15, 2020
The file extension for export/print archives is still called `.sd-export`
@eloquence eloquence changed the title Add more styling to auth widget Adjust clickable target area in auth widget and style sign-out menu Mar 20, 2020
@eloquence
Copy link
Member

Adjusting the clickable target area to include the initials is a nice candidate issue for @ntoll so keeping on milestone for now.

@eloquence
Copy link
Member

As clarified in #850 the sign-out design in this issue is outdated. #976 has improved the clickable target area, but is not fully to spec. I'm going to close this issue and open a new tightly scoped one to further tweak the click target area.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants