Provide mime and paxctld configuration for template consolidation #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Provides files required to open in a DispVM by default * Provides mime handling definitions for sd-app, sd-devices and sd-viewer AppVMs to be handled by salt
Current versions of securedrop-client, securedrop-export, securedrop-workstation-svs-disp already manage this file in /usr/share/applications/, which causes an error on install. In order to allow the coexistance of these packages, we need to place and move these files manually ourselves. Once we clean up the other packages (at the final phase of template-consolidation) we can manage this file properly directly through the .install file, and have it handled by this package. All other packages (client, export, svs-disp) will not handle the mimetype config, it will be handled via salt in AppVM's private volume.
8 tasks
30 tasks
5 tasks
conorsch
pushed a commit
to freedomofpress/securedrop-client
that referenced
this pull request
Oct 19, 2020
As part of template consolidation [0], we've moved all mimetype associations into the "securedrop-workstation-config" package [1]. The "open-in-dvm" desktop file now resides in the same package [2]. [0] freedomofpress/securedrop-workstation#471 [1] freedomofpress/securedrop-builder#190 [2] freedomofpress/securedrop-builder#198
conorsch
pushed a commit
to freedomofpress/securedrop-client
that referenced
this pull request
Oct 27, 2020
As part of template consolidation [0], we've moved all mimetype associations into the "securedrop-workstation-config" package [1]. The "open-in-dvm" desktop file now resides in the same package [2]. [0] freedomofpress/securedrop-workstation#471 [1] freedomofpress/securedrop-builder#190 [2] freedomofpress/securedrop-builder#198
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #188 , test plan can be found in TBD
Due to order-of-operations, we will need to add the defensive mimetype configuration after the clean up and consolidation, as
securedrop-client,securedrop-exportandsecuredrop-workstation-svs-dispare competing with/usr/share/applications/mimeapps.list, and we do not want to introduce breakage of the functionality provided by securedrop-export` (I propose we open a follow-up issue)