Improve the workflow for creating RPM packages for Qubes - #34
Merged
Conversation
Remove the unnecessary uv build restriction, and try to work with whatever is available in our system, since we don't have any particular requirements. The trigger for this change is that `uv-build` in Fedora 43 has moved forward than version 0.10.x, which is unusable with the current restrictions.
Make the build script location-agnostic, so that we can run it even outside the `dangerzone-image` repo.
Update the Qubes build instructions with containerized and non-containerized instructions.
almet
reviewed
Jun 30, 2026
The `make Dockerfile` command does not run in a CI environment, because the source and target are already there, and with the same timestamp. Currently, this step reports: make: 'Dockerfile' is up to date. Use the `-B` flag to always regenerate the Dockerfile.
almet
approved these changes
Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current way we build RPM packages for Qubes has a couple of problems:
uv_buildrestriction is too strict, and the latestpython3-uv-buildpackage from Fedora 43 cannot satisfy it.freedomofpress/dangerzonerepo, which invoke this script outside thedangerzone-image/dir.imagescript.This PR fixes the above problems. A similar PR will land on the Dangerzone repo, that works on top of this PR and builds RPM packages for Qubes more easily.