zfsboot: fix misuse of the phrase zpool #1569
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A pool is not a zpool.
bsdjhb
approved these changes
Jan 24, 2025
grahamperrin
commented
Jan 26, 2025
| @@ -1007,7 +1007,7 @@ zfs_create_diskpart() | |||
| f_eval_catch $funcname gpart "$GPART_CREATE" BSD ${disk}s1 || | |||
| return $FAILURE | |||
|
|
|||
| # NB: zpool will use s1a (no labels) | |||
| # NB: ZFS pool will use s1a (no labels) | |||
There was a problem hiding this comment.
Suggested change
| # NB: ZFS pool will use s1a (no labels) | |
| # NB: ZFS pools will use s1a (no labels) |
There was a problem hiding this comment.
as you are reviewing your own commit (and this seems fine) could you update the branch to include this change?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A pool is not a zpool.
Consistent with fixes in doc 1fb34fa0530a for
https://bugs.freebsd.org/257405