Skip to content
This repository has been archived by the owner on Oct 16, 2019. It is now read-only.

Fix: Hint Button #196

Merged
merged 2 commits into from
Jun 28, 2018
Merged

Fix: Hint Button #196

merged 2 commits into from
Jun 28, 2018

Conversation

Bouncey
Copy link
Member

@Bouncey Bouncey commented Jun 25, 2018

Do not merge until the corresponding guide PR has been merged.

Depends on freeCodeCamp/guide#8217

Copy link
Member

@raisedadead raisedadead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM.

Copy link

@scissorsneedfoodtoo scissorsneedfoodtoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything LGTM too!

Just one thing I noticed is that maybe the text for the button should read "Get a Hint" with capitalization similar to the "Run the Tests" and "Reset All Code" buttons. If we want to go that way, we can change "Ask for help" to "Ask for Help" in the future. We could go the other way, too, with only the first word of each button capitalized. What do you both think?

@raisedadead raisedadead merged commit fd5d384 into freeCodeCamp:master Jun 28, 2018
@Bouncey Bouncey deleted the feat/guideUrl branch June 28, 2018 20:11
Bouncey added a commit to Bouncey/learn that referenced this pull request Jul 27, 2018
* Create a guide URL for each challenge

* Format
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants