Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(curriculum): Accessibility Quiz use rem units for font-size #55856

Merged
merged 4 commits into from
Oct 8, 2024
Merged

fix(curriculum): Accessibility Quiz use rem units for font-size #55856

merged 4 commits into from
Oct 8, 2024

Conversation

Supravisor
Copy link
Contributor

Checklist:

Related to #47830

Replace px units with rem units for font-size attribute values.
Should fix: number 3

@github-actions github-actions bot added the scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. label Aug 14, 2024
@moT01 moT01 added the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Aug 23, 2024
a2937
a2937 approved these changes Oct 7, 2024
View reviewed changes
Copy link
Member

@a2937 a2937 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything here passes and it certainly appears that 16px is indeed the base for the rem units. As such I'm going to approve this.

moT01
moT01 approved these changes Oct 8, 2024
View reviewed changes
Copy link
Member

@moT01 moT01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@moT01 moT01 merged commit e8e8425 into freeCodeCamp:main Oct 8, 2024
22 checks passed
@Supravisor Supravisor deleted the a11yQuizRem branch October 8, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moT01 moT01 moT01 approved these changes

@a2937 a2937 a2937 approved these changes

Assignees
No one assigned
Labels
scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Supravisor @a2937 @moT01