fix(curriculum): new step for empty title bug #55730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
scope: curriculum
naomi-lgbt
requested changes
Aug 5, 2024
...and-data-structures-22/learn-localstorage-by-building-a-todo-app/66ad0f178ed5791ed898fe56.md
Outdated
Show resolved
Hide resolved
...and-data-structures-22/learn-localstorage-by-building-a-todo-app/66ad0f178ed5791ed898fe56.md
Outdated
Show resolved
Hide resolved
...and-data-structures-22/learn-localstorage-by-building-a-todo-app/66ad0f178ed5791ed898fe56.md
Outdated
Show resolved
Hide resolved
…a-structures-22/learn-localstorage-by-building-a-todo-app/66ad0f178ed5791ed898fe56.md Co-authored-by: Naomi the Technomancer <accounts+github@nhcarrigan.com>
…a-structures-22/learn-localstorage-by-building-a-todo-app/66ad0f178ed5791ed898fe56.md Co-authored-by: Naomi the Technomancer <accounts+github@nhcarrigan.com>
…a-structures-22/learn-localstorage-by-building-a-todo-app/66ad0f178ed5791ed898fe56.md Co-authored-by: Naomi the Technomancer <accounts+github@nhcarrigan.com>
…Camp into new-challenge-blank-space
…bhullar-tech/freeCodeCamp into new-challenge-blank-space
ilenia-magoni
requested changes
Sep 1, 2024
...and-data-structures-22/learn-localstorage-by-building-a-todo-app/66ad0f178ed5791ed898fe56.md
Outdated
Show resolved
Hide resolved
...and-data-structures-22/learn-localstorage-by-building-a-todo-app/66ad0f178ed5791ed898fe56.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Ilenia <26656284+ilenia-magoni@users.noreply.github.com>
Co-authored-by: Ilenia <26656284+ilenia-magoni@users.noreply.github.com>
moT01
added
the
status: waiting review
moT01
reviewed
Sep 12, 2024
There was a problem hiding this comment.
I don't think the description explains enough for users to be able to complete this. The only way they will know what code to write is by looking at the hints. If the test is going to require using certain code or methods, we need to explain that in the description.
moT01
added
status: waiting update
|
@moT01 can you please let me know what should be the description in that case. |
moT01
requested changes
Sep 26, 2024
There was a problem hiding this comment.
Sorry for the delay @gagan-bhullar-tech. I left a comment with a new description. Let me know if you have any suggestions for improvements on it. Also found a few minor things that weren't needed in the regex tests.
...and-data-structures-22/learn-localstorage-by-building-a-todo-app/66ad0f178ed5791ed898fe56.md
Outdated
Show resolved
Hide resolved
...and-data-structures-22/learn-localstorage-by-building-a-todo-app/66ad0f178ed5791ed898fe56.md
Outdated
Show resolved
Hide resolved
...and-data-structures-22/learn-localstorage-by-building-a-todo-app/66ad0f178ed5791ed898fe56.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
|
@moT01 thanks. Updated PR. |
moT01
approved these changes
Oct 8, 2024
moT01
added
status: waiting review
naomi-lgbt
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
mainbranch of freeCodeCamp.Closes #54588