Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api): use port 27017 #54220

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

ShaunSHamilton
Copy link
Member

Checklist:

There is no reason to use a different port. Using a non-default port:

  • Requires specific config to use mongosh/compass
  • Catches me off-guard every time I switch context between old api and new api.

@ShaunSHamilton ShaunSHamilton requested a review from a team as a code owner March 26, 2024 10:17
@github-actions github-actions bot added the platform: api Server application that needs familiarity with Express, Loopback, MongoDB etc. label Mar 26, 2024
@moT01 moT01 added the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Mar 26, 2024
Copy link
Member

@moT01 moT01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if I'm missing something - but when I try to interact with the database, I get "Prisma needs to perform transactions, which requires your MongoDB server to be run as a replica set." Which I didn't see before. Am I not doing something correct?

I feel like that might be the reason this is on a different port.

@ShaunSHamilton
Copy link
Member Author

I'm not sure if I'm missing something - but when I try to interact with the database, I get "Prisma needs to perform transactions, which requires your MongoDB server to be run as a replica set." Which I didn't see before. Am I not doing something correct?

I did not get anything like that. Provided you still have the same connection string in your .env (like in the sample.env) with the ?directConnection=true, then you should not see that error.

Copy link
Member

@naomi-lgbt naomi-lgbt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something something "so we could run them both at the same time and compare functionality"

@naomi-lgbt naomi-lgbt merged commit c98e180 into freeCodeCamp:main Apr 3, 2024
23 checks passed
@ShaunSHamilton ShaunSHamilton deleted the fix_api-db-port branch April 3, 2024 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform: api Server application that needs familiarity with Express, Loopback, MongoDB etc. status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants