-
-
Notifications
You must be signed in to change notification settings - Fork 41.4k
feat(learn): add mocha and chai instructions #39976
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Is there something specific you aren't sure on or want some input on @SKY020? I only took a glance at the diff, it looks like it's on the right track. I noticed there was a new lesson added - that one was in the boilerplate but not on /learn or something? |
@moT01 The original (and final) lesson in /learn](https://www.freecodecamp.org/learn/quality-assurance/quality-assurance-and-testing-with-chai/run-functional-tests-using-a-headless-browser-ii) basically just says "now, follow the instructions in the boilerplate"
There are a lot of instructions in the boilerplate, from this section. So, I suspect, I will be adding 4 - 5 lessons. Do you have anything against this? |
Not if it's necessary - I haven't gone through it to know if that's the case. I can take a look. |
I went through it - there's an awful lot of instructions in the boilerplate, not to mention confusion on some of the lessons. Unless I'm missing something, there is a page on /learn for that final lesson - you linked to it - so I don't think that additional lesson you added is necessary? I'm not sure adding other lessons is necessary either - did you have some in mind that you wanted to explain certain areas better? I feel like the lessons can possibly remain how they are if we can write good instructions on learn for them. I feel like that's what we should shoot for. But maybe if I were to try to do it, I would be in favor of adding more - so I'm not entirely sure. |
@moT01 I am very confused by your above comment. Are you saying we should try to fit everything into one lesson? |
Yes, I am saying that we try and fit everything into the existing lessons and not add more. There would need to be some significant rewriting to accomplish that, but I think it's possible. That's my opinion anyway - but I'm not completely against adding more. I think the overall plan was to not add more lessons since the project based curriculum was announced, but I'm sure an exception could be made if it's necessary. To try and clarify, and maybe you aren't sure yet - but you want to take that last lesson (the one you linked to), and break it up into several lessons? I'm not sure which specific lesson you are referring to. Here, I made a potential example for the second to last lesson |
@moT01 I have pushed what I thought might work. (I still need to figure something out with the boilerplate) On a side note: Do you have any idea how I could accomplish what I have done with the ordered-lists, without Husky (linter) complaining? |
Try just using 1 for all the numbers...
=
|
I actually don't mind breaking that one up - that was the one I thought made the most sense. If we do keep it broken up like that, I would maybe keep the title and mongo id the same for the other two headless lessons and give the new one a new title and mongoid. Maybe "Simulate actions using a Headless Browser". I suppose it works either way, but that's another way I guess. |
curriculum/challenges/_meta/quality-assurance-and-testing-with-chai/meta.json
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SKY020 See my suggested changes.
@SKY020 You will need to look at my suggestions on PR freeCodeCamp/boilerplate-mochachai#27 to understand how these changes will need related to the boilerplate changes If you have any questions, let me know or contact me on Gitter and we can set up a meeting to discuss the changes further.
...ty-assurance/quality-assurance-and-testing-with-chai/learn-how-javascript-assertions-work.md
Outdated
Show resolved
Hide resolved
...ity-assurance-and-testing-with-chai/run-functional-tests-on-api-endpoints-using-chai-http.md
Outdated
Show resolved
Hide resolved
...-assurance-and-testing-with-chai/run-functional-tests-on-api-endpoints-using-chai-http-ii.md
Outdated
Show resolved
Hide resolved
@SKY020 I sent you a message on Gitter to explain how to add one of the examples to the applicable |
Co-authored-by: Randell Dawson <rdawson@onepathtech.com>
@RandellDawson The boilerplate is ready. The only thing left to discuss is |
Just do your best at a first pass. We can tweak it once you get something in the description section and the comments removed from the example code. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SKY020 In addition to the changes requested, can you also add backticks around the methods in the following lines of curriculum/challenges/english/06-quality-assurance/quality-assurance-and-testing-with-chai/learn-how-javascript-assertions-work.md
- text: You should choose the right assertion - isNull vs. isNotNull.
- text: You should choose the right assertion - isNull vs. isNotNull.
Actually, it would be nice if these text
could explain what they are supposed to be testing. As it reads right now, they are the exact same text even though the testString
s are different. In fact, if you see other such text
in other challenges of this same section, go ahead and fix those too.
...ty-assurance-and-testing-with-chai/assert-deep-equality-with-.deepequal-and-.notdeepequal.md
Outdated
Show resolved
Hide resolved
...-assurance/quality-assurance-and-testing-with-chai/compare-the-properties-of-two-elements.md
Outdated
Show resolved
Hide resolved
This is failing a Project Euler challenge?! |
It looks like the runtime closed - so maybe a timeout issue? The solution for that Euler challenge passes all the tests on the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I'm good with the changes on this PR 🎉 Nice job @SKY020 🎉
I left a comment on the boilerplate PR that needs to be looked into I think.
Edit: I think we should wait with this one until we figure out the problem with the boilerplate.
This should be good to go now pending another review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM~! 🥳 I ran through the new challenges with the updated boilerplate and everything seemed clear enough.
Thank you for your pull request! We look forward to additional contributions!
Checklist:
Update index.md
)master
branch of freeCodeCamp.Related to: #39720
Please note: I am aware of how to add new challenges...this was just a quick-test