-
-
Notifications
You must be signed in to change notification settings - Fork 39k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve test on jQuery disable challenge #10412
Improve test on jQuery disable challenge #10412
Conversation
763309f
to
40d5d27
Compare
@dhcodes updated the pull request. |
Thanks for the PR @dhcodes. One thing about this approach is that it will now no longer catch cases where someone simply uses
There might be some edge cases I missed, but basically this will look for any instance of |
@ltegman good idea, I hadn't considered that. I'll update this today (hopefully). |
40d5d27
to
c569fe8
Compare
@dhcodes updated the pull request. |
c569fe8
to
4da43ae
Compare
@dhcodes updated the pull request. |
4da43ae
to
80b2d69
Compare
@dhcodes updated the pull request. |
Okay. Sorry if you got notifications for all that @ltegman. Should be good to go now. Sorry it took so long. I need even more git practice apparently. |
Not a problem -- only way you get good at git is by making mistakes with git! 😆 Looks good! 👍 |
Pre-Submission Checklist
staging
branch of FreeCodeCamp.fix/
,feature/
, ortranslate/
(e.g.fix/signin-issue
)npm run test-challenges
. Usegit commit --amend
to amend any fixes.Type of Change
Checklist:
Description
Updated the third test to look for
disabled\s?=
whereas before it looked fordisabled>