-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add NuxtJS documentation (2.15.8) #1832
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, thank you for this work. Great! Please see my comment on the license, it might be incompatible :/
'NuxtJS', | ||
'2016-present Nuxt Team', | ||
'MIT', | ||
'https://raw.githubusercontent.com/nuxt/nuxt.js/dev/LICENSE' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'https://raw.githubusercontent.com/nuxt/nuxt.js/dev/LICENSE' | |
'https://raw.githubusercontent.com/nuxt/nuxtjs.org/main/LICENSE.md' |
Here, we display the license of the docs not the source code.
This one uses https://creativecommons.org/licenses/by-nd/4.0/ "Creative Commons Attribution-NoDerivatives 4.0" – is devdocs.io a derivative? Rather yes? https://creativecommons.org/faq/#what-is-an-adaptation
Here's how we dealt with it in the past #1752 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will try reach out to them to get some clarification. But yeah seems this would be a blocker
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have made some updates to the mc-stan issue regarding the no derivatives clause of the CC license.
class Nuxtjs | ||
class ContainerFilter < Filter | ||
def call | ||
at_css '.docus-content' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Simply use options[:container] = '.docus-content'
in lib/docs/scrapers/nuxtjs.rb
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe I tried that but it didn't end up following links and thus didn't do a full scrape. But I guess will have to tackle the license issue first 😅
Fixes: #1727
If you’re adding a new scraper, please ensure that you have:
public/icons/your_scraper_name/
directory:16.png
: a 16×16 pixel icon for the doc16@2x.png
: a 32×32 pixel icon for the docSOURCE
: A text file containing the URL to the page the image can be found on or the URL of the original image itselfPreview