chore: updating world map workshop prototype#1136
chore: updating world map workshop prototype#1136danielfreire-dev wants to merge 5 commits intofreeCodeCamp:mainfrom
Conversation
|
what issue is this change related to? |
|
Are you part of Naomi's sprints? If so, please provide details on what this PR is in relation to so we better understand the context for these changes. Are you working on a lab or workshop? |
|
Yes, I am part of Naomi's Sprints.
EDIT: added one more item |
majestic-owl448
left a comment
majestic-owl448
left a comment
There was a problem hiding this comment.
please mention the issue when you create a PR
please update the title so that it follows the docs https://contribute.freecodecamp.org/#/how-to-open-a-pull-request?id=prepare-a-good-pr-title
the csv data needs to go on the CDN repo (https://github.com/freeCodeCamp/cdn) and should be fetched (with d3 that is d3.json(url)
we are not able to have d3 as a minified version, this is the html for an other d3 project, you need to import `d3 in a similar way in your project
<!DOCTYPE html>
<html lang="en">
<head>
<meta charset="UTF-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<title>Build a Scatterplot Graph</title>
<link rel="stylesheet" href="styles.css" />
<script src="https://cdnjs.cloudflare.com/ajax/libs/d3/7.9.0/d3.min.js"></script>
</head>
<body>
<script src="script.js"></script>
</body>
</html>because of how the editor works in the freeCodeCamp environment, the JS file name should be script.js and the CSS file name should be styles.css
danielfreire-dev
changed the title
danielfreire-dev
changed the title
danielfreire-dev
changed the title
danielfreire-dev
changed the title
…re and requests an online version of the csv file
jdwilkin4
changed the title
jdwilkin4
added
workshop
status: waiting review
full stack cert
and removed
awaiting update
labels
jdwilkin4
left a comment
jdwilkin4
left a comment
There was a problem hiding this comment.
Can you move this project over to the full stack folder? it will be easier to find all of these projects in one place later on.
https://github.com/freeCodeCamp/CurriculumExpansion/tree/main/fullstack-cert/d3-projects
…nt-end-libs' -> 'full-stack-certs'
…nt-end-libs' -> 'full-stack-certs'
majestic-owl448
moved this from In progress
to In review
in Naomi's Contribution Sprints
jdwilkin4
left a comment
jdwilkin4
left a comment
There was a problem hiding this comment.
It looks like you have a lot of extra files that don't need to be there.
You should only have three files.
An HTML file, CSS file and js file.
Once you resolve that, then we can review your project 👍🏾
|
Did you need help resolve the extra files listed here? |
|
I created a new PR to add these files to the CDN. I am waiting for its approval. EDIT: grammar |
|
I left comments on your PR for the CDN repo. 
That will also need to be resolved before another review can be done |
3 participants
Checklist:
Update index.md)relates to #64629