refactor #37

a3828162 · 2024-05-08T09:02:09Z

ianchen0119 · 2024-05-15T05:06:58Z

Hi @a3828162

Please help to resolve the conflicts in pkg/service/init.go.
Tks!

…actor/sbi-logic

pkg/service/init.go

cmd/main.go

internal/sbi/consumer/nf_management_test.go

internal/sbi/eventexposure/api_create_ee_subscription.go

cmd/main.go

internal/sbi/processor/processor.go

internal/sbi/router.go

pkg/service/init.go

internal/sbi/consumer/nrf_service.go

andy89923

Also, need to fix the Termination procedure; you could refer to the Discord message.

pkg/service/init.go

internal/sbi/consumer/nrf_service.go

internal/sbi/server.go

internal/sbi/processor/callback.go

internal/sbi/api_uecontextmanagement.go

internal/sbi/server.go

internal/sbi/processor/enent_exposure.go

ianchen0119

Please ensure the implementations of processor pkg follow our standard.

…ndard

internal/sbi/processor/ue_context_management.go

internal/sbi/api_parameterprovision.go

internal/sbi/api_subscriberdatamanagement.go

ianchen0119 · 2024-06-27T05:53:12Z

internal/sbi/processor/processor.go

+	consumer *consumer.Consumer
+}
+
+func NewProcessor(udm ProcessorUdm) (*Processor, error) {


Please refer to https://github.com/free5gc/amf/pull/132/files

You don't need to implement the Consumer getter here.

ianchen0119

LGTM (except for my commented part)

a3828162 added 6 commits April 24, 2024 09:40

feat: consumer nrf_service

23b2cdc

feat: add nudm_service.go and nudr_service.go in consumer/

f50f25d

feat: refactor processor ee, pp, callback

21c90fb

feat: refactor uecm api_{SRV}.go and sdm api_{SRV}.go

aef8bce

feat: change func name http to handle, add (processor) method

1e67491

feat: refactor server, processsor, consumer, router

2d42b1a

a3828162 and others added 5 commits May 15, 2024 15:25

Merge branch 'main' into refactor/sbi-logic

b8715f9

feat: refactor router

4076213

Merge branch 'refactor/sbi-logic' of github.com:a3828162/udm into ref…

d2386b3

…actor/sbi-logic

fix: fix lint error

c563d3e

feat: move procedure, hand func

dfb8312

yccodr reviewed May 23, 2024

View reviewed changes

pkg/service/init.go Outdated Show resolved Hide resolved

fix: name error

2decf1b

ianchen0119 reviewed May 24, 2024

View reviewed changes

cmd/main.go Outdated Show resolved Hide resolved

ianchen0119 reviewed May 24, 2024

View reviewed changes

internal/sbi/consumer/nf_management_test.go Outdated Show resolved Hide resolved

ianchen0119 reviewed May 24, 2024

View reviewed changes

internal/sbi/eventexposure/api_create_ee_subscription.go Outdated Show resolved Hide resolved

ianchen0119 reviewed May 24, 2024

View reviewed changes

cmd/main.go Outdated Show resolved Hide resolved

ianchen0119 self-assigned this May 24, 2024

a3828162 and others added 3 commits May 26, 2024 16:00

fix: fix run error, remove unuse line

f066b7c

fix: consumer init error, url.Value init error

e3f5dea

fix: add mock app interface & fix unit test

bc28dff

ianchen0119 marked this pull request as ready for review May 29, 2024 07:13

delete: remove legacy code

8f668bb

andy89923 reviewed Jun 4, 2024

View reviewed changes

fix: fix with PR comment

76c53ec

ming-hsien reviewed Jun 12, 2024

View reviewed changes

internal/sbi/consumer/nrf_service.go Show resolved Hide resolved

andy89923 reviewed Jun 21, 2024

View reviewed changes

pkg/service/init.go Outdated Show resolved Hide resolved

internal/sbi/consumer/nrf_service.go Outdated Show resolved Hide resolved

fix: fix PR comment & terminate problem

6cf39c6

andy89923 reviewed Jun 22, 2024

View reviewed changes

internal/sbi/server.go Outdated Show resolved Hide resolved

internal/sbi/server.go Outdated Show resolved Hide resolved

internal/sbi/processor/callback.go Outdated Show resolved Hide resolved

internal/sbi/api_uecontextmanagement.go Outdated Show resolved Hide resolved

a3828162 added 2 commits June 24, 2024 05:52

fix: fix PR comment

2d138ca

fix: fix log

0465bd4

ianchen0119 reviewed Jun 25, 2024

View reviewed changes

internal/sbi/server.go Outdated Show resolved Hide resolved

ianchen0119 reviewed Jun 25, 2024

View reviewed changes

internal/sbi/processor/enent_exposure.go Outdated Show resolved Hide resolved

ianchen0119 requested changes Jun 25, 2024

View reviewed changes

fix: fix wrong file name & fix implementation of processor follow sta…

4e578fd

…ndard

a3828162 requested a review from ianchen0119 June 25, 2024 07:52

andy89923 reviewed Jun 25, 2024

View reviewed changes

internal/sbi/processor/ue_context_management.go Outdated Show resolved Hide resolved

internal/sbi/processor/ue_context_management.go Outdated Show resolved Hide resolved

internal/sbi/processor/ue_context_management.go Outdated Show resolved Hide resolved

a3828162 added 2 commits June 25, 2024 10:46

fix: fix PR comment

0001050

fix: fix PR comment

d4025e0

andy89923 reviewed Jun 26, 2024

View reviewed changes

fix : fix PR comment

395e622

andy89923 approved these changes Jun 26, 2024

View reviewed changes

ianchen0119 reviewed Jun 27, 2024

View reviewed changes

fix: fix PR comment

972efcf

ianchen0119 approved these changes Jun 27, 2024

View reviewed changes

ianchen0119 merged commit 3f28447 into free5gc:main Jun 27, 2024
2 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor #37

refactor #37

a3828162 commented May 8, 2024 •

edited

Loading

ianchen0119 commented May 15, 2024

andy89923 left a comment

ianchen0119 left a comment

ianchen0119 Jun 27, 2024

ianchen0119 left a comment

refactor #37

refactor #37

Conversation

a3828162 commented May 8, 2024 • edited Loading

ianchen0119 commented May 15, 2024

andy89923 left a comment

Choose a reason for hiding this comment

ianchen0119 left a comment

Choose a reason for hiding this comment

ianchen0119 Jun 27, 2024

Choose a reason for hiding this comment

ianchen0119 left a comment

Choose a reason for hiding this comment

a3828162 commented May 8, 2024 •

edited

Loading