Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A few linux <> host behavior changes #63

Open
baconpaul opened this issue Jun 22, 2022 · 1 comment · Fixed by #68
Open

A few linux <> host behavior changes #63

baconpaul opened this issue Jun 22, 2022 · 1 comment · Fixed by #68

Comments

@baconpaul
Copy link
Collaborator

1: If the host does not support the timer, many things won't work especially our GUI. Have the extensions at least return false for hasgui if there's no timer
2. We start the timer in ::init since JUCE needs it pretty early. That led to some controversy free-audio/clap#111 and although we thought it was OK, it may be more defensive to have init request a main thread callback to start the timer.
@baconpaul baconpaul mentioned this issue Jun 23, 2022
Merged
baconpaul added a commit that referenced this issue Jun 23, 2022
@baconpaul
A few linux behavior changes (#68)
d4c2c05 
1. Call the timer register in a deferred callback launched from
   init
2. implementsGui has a `canUseTimerSupport` check
3. Clarifying comments per review

Closes #63
@baconpaul baconpaul reopened this Jun 23, 2022
@baconpaul
Copy link
Collaborator Author

I reverted that change because while it fixed the Linux issue it segv bws 43b8 macos. @abique has that fixed so when 43b9 is out we can reapply and merge that branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

A few linux behavior changes baconpaul/clap-juce-extensions
1 participant
@baconpaul