refactor default options merge to avert side effects. #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
```
$.extend(defaults, options);
```
will overwrite the default variable with ```options```. So if there are two endless scrolls on the page, the 2nd endless scroll could receive 'dirty' defaults from the first call.
This:
```
$.extend({}, defaults, options);
```
won't do that. It keeps defaults clean and separate from the intended options.
fredwu
added a commit
that referenced
this pull request
Nov 17, 2011
refactor default options merge to avert side effects.
|
Merged and tagged a new release! Thanks! :) |
|
welcome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
setting options this way:
will overwrite the default variable with the param
options.For example, If there are two endless scrolls on the page, the 2nd endless scroll could receive 'dirty' defaults from the first call.
This:
won't do that. It keeps defaults clean and separate from the intended options.