feat: paginate silences

.golangci.yml

@@ -44,3 +44,4 @@ linters:
     - mnd
     - perfsprint
     - testpackage
+    - interfacebloat

pkg/app/app.go

@@ -82,6 +82,8 @@
 	a.Bot.Handle("/alertmanager_unsilence", a.HandleDeleteSilenceViaCommand(a.Alertmanager))
 
 	// Callbacks
+	a.Bot.Handle("\f"+constants.GrafanaPaginatedSilencesList, a.HandleListSilencesFromCallback(a.Grafana))
+	a.Bot.Handle("\f"+constants.AlertmanagerPaginatedSilencesList, a.HandleListSilencesFromCallback(a.Alertmanager))
 	a.Bot.Handle("\f"+constants.GrafanaUnsilencePrefix, a.HandleCallbackDeleteSilence(a.Grafana))
 	a.Bot.Handle("\f"+constants.AlertmanagerUnsilencePrefix, a.HandleCallbackDeleteSilence(a.Alertmanager))
 	a.Bot.Handle("\f"+constants.GrafanaPrepareSilencePrefix, a.HandlePrepareNewSilenceFromCallback(a.Grafana, a.Grafana))

pkg/app/silences_list.go

@@ -6,6 +6,7 @@
 	"main/pkg/types"
 	"main/pkg/types/render"
 	"main/pkg/utils/generic"
+	"strconv"
 
 	tele "gopkg.in/telebot.v3"
 )
@@ -18,57 +19,123 @@
 			Str("silence_manager", silenceManager.Name()).
 			Msg("Got list silence query")
 
-		if !silenceManager.Enabled() {
-			return c.Reply(silenceManager.Name() + " is disabled.")
-		}
+		return a.HandleListSilencesWithPagination(c, silenceManager, 0, false)
+	}
+}
+
+func (a *App) HandleListSilencesFromCallback(silenceManager types.SilenceManager) func(c tele.Context) error {
+	return func(c tele.Context) error {
+		callback := c.Callback()
 
-		silencesWithAlerts, err := types.GetSilencesWithAlerts(silenceManager)
+		a.Logger.Info().
+			Str("sender", c.Sender().Username).
+			Str("silence_manager", silenceManager.Name()).
+			Str("data", callback.Data).
+			Msg("Got list silence query via callback")
+
+		page, err := strconv.Atoi(callback.Data)
 		if err != nil {
-			return c.Reply(fmt.Sprintf("Error fetching silences: %s\n", err))
+			return c.Reply("Failed to parse page number from callback!")
 		}
 
-		silencesGrouped := generic.SplitArrayIntoChunks(silencesWithAlerts, constants.SilencesInOneMessage)
-		if len(silencesGrouped) == 0 {
-			silencesGrouped = [][]types.SilenceWithAlerts{{}}
+		return a.HandleListSilencesWithPagination(c, silenceManager, page, true)
+	}
+}
+
+func (a *App) HandleListSilencesWithPagination(
+	c tele.Context,
+	silenceManager types.SilenceManager,
+	page int,
+	editPrevious bool,
+) error {
+	if !silenceManager.Enabled() {
+		return c.Reply(silenceManager.Name() + " is disabled.")
+	}
+
+	silencesWithAlerts, err := types.GetSilencesWithAlerts(silenceManager)
+	if err != nil {
+		return c.Reply(fmt.Sprintf("Error fetching silences: %s\n", err))
+	}
+
+	silencesGrouped := generic.SplitArrayIntoChunks(silencesWithAlerts, constants.SilencesInOneMessage)
+	if len(silencesGrouped) == 0 {
+		silencesGrouped = [][]types.SilenceWithAlerts{{}}
+	}
+
+	chunk := []types.SilenceWithAlerts{}
+	if page < len(silencesGrouped) {
+		chunk = silencesGrouped[page]
+	}
+
+	template, renderErr := a.TemplateManager.Render("silences_list", render.RenderStruct{
+		Grafana:      a.Grafana,
+		Alertmanager: a.Alertmanager,
+		Data: types.SilencesListStruct{
+			Silences:      chunk,
+			ShowHeader:    true,
+			Start:         page*constants.SilencesInOneMessage + 1,
+			End:           page*constants.SilencesInOneMessage + len(chunk),
+			SilencesCount: len(silencesWithAlerts),
+		},
+	})
+
+	if renderErr != nil {
+		a.Logger.Error().Err(renderErr).Msg("Error rendering silences_list template")
+		return c.Reply(fmt.Sprintf("Error rendering template: %s", renderErr))
+	}
+
+	menu := &tele.ReplyMarkup{ResizeKeyboard: true}
+
+	rows := make([]tele.Row, 0)
+
+	for _, silence := range chunk {
+		button := menu.Data(
+			fmt.Sprintf("❌Unsilence %s", silence.Silence.ID),
+			silenceManager.GetUnsilencePrefix(),
+			silence.Silence.ID,
+		)
+
+		rows = append(rows, menu.Row(button))
+	}
+
+	if len(chunk) > 0 {
+		buttons := []tele.Btn{}
+		if page >= 1 {
+			buttons = append(buttons, menu.Data(
+				fmt.Sprintf("⬅️Page %d", page),
+				silenceManager.GetPaginatedSilencesListPrefix(),
+				strconv.Itoa(page-1),
+			))
 		}
 
-		for index, chunk := range silencesGrouped {
-			template, renderErr := a.TemplateManager.Render("silences_list", render.RenderStruct{
-				Grafana:      a.Grafana,
-				Alertmanager: a.Alertmanager,
-				Data: types.SilencesListStruct{
-					Silences:      chunk,
-					ShowHeader:    index == 0,
-					SilencesCount: len(silencesWithAlerts),
-				},
-			})
-
-			if renderErr != nil {
-				a.Logger.Error().Err(renderErr).Msg("Error rendering silences_list template")
-				return c.Reply(fmt.Sprintf("Error rendering template: %s", renderErr))
-			}
-
-			menu := &tele.ReplyMarkup{ResizeKeyboard: true}
-
-			rows := make([]tele.Row, constants.SilencesInOneMessage)
-
-			for silenceIndex, silence := range chunk {
-				button := menu.Data(
-					fmt.Sprintf("❌Unsilence %s", silence.Silence.ID),
-					silenceManager.GetUnsilencePrefix(),
-					silence.Silence.ID,
-				)
-
-				rows[silenceIndex] = menu.Row(button)
-			}
-
-			menu.Inline(rows...)
-
-			if sendErr := a.BotReply(c, template, menu); sendErr != nil {
-				a.Logger.Error().Err(sendErr).Msg("Error sending message")
-			}
+		if page < len(silencesGrouped)-1 {
+			buttons = append(buttons, menu.Data(
+				fmt.Sprintf("➡️Page %d", page+2),
+				silenceManager.GetPaginatedSilencesListPrefix(),
+				strconv.Itoa(page+1),
+			))
+		}
+
+		if len(buttons) > 0 {
+			rows = append(rows, menu.Row(buttons...))
+		}
+	}
+
+	menu.Inline(rows...)
+
+	if editPrevious {
+		if editErr := c.Edit(template, menu, tele.ModeHTML, tele.NoPreview); editErr != nil {
+			a.Logger.Error().Err(editErr).Msg("Error deleting previous message")
+			return editErr
 		}
 
 		return nil
 	}
+
+	if sendErr := a.BotReply(c, template, menu); sendErr != nil {
+		a.Logger.Error().Err(sendErr).Msg("Error sending message")
+		return sendErr
+	}
+
+	return nil
 }

pkg/clients/alertmanager.go

@@ -42,6 +42,10 @@
 	return constants.AlertmanagerSilencePrefix
 }
 
+func (g *Alertmanager) GetPaginatedSilencesListPrefix() string {
+	return constants.AlertmanagerPaginatedSilencesList
+}
+
 func (g *Alertmanager) GetMutesDurations() []string {
 	return g.Config.MutesDurations
 }

pkg/clients/grafana.go

@@ -43,6 +43,10 @@
 	return constants.GrafanaSilencePrefix
 }
 
+func (g *Grafana) GetPaginatedSilencesListPrefix() string {
+	return constants.GrafanaPaginatedSilencesList
+}
+
 func (g *Grafana) Name() string {
 	return "Grafana"
 }

pkg/constants/constants.go

@@ -6,12 +6,14 @@ const (
 	SilenceMatcherEqual         string = "="
 	SilenceMatcherNotEqual      string = "!="
 
-	SilencesInOneMessage             = 5
-	AlertsInOneMessage               = 3
-	GrafanaUnsilencePrefix           = "grafana_unsilence_"
-	AlertmanagerUnsilencePrefix      = "alertmanager_unsilence_"
-	GrafanaSilencePrefix             = "grafana_silence_"
-	AlertmanagerSilencePrefix        = "alertmanager_silence_"
-	GrafanaPrepareSilencePrefix      = "grafana_prepare_silence_"
-	AlertmanagerPrepareSilencePrefix = "alertmanager_prepare_silence_"
+	SilencesInOneMessage              = 5
+	AlertsInOneMessage                = 3
+	GrafanaPaginatedSilencesList      = "grafana_paginated_silences_list"
+	AlertmanagerPaginatedSilencesList = "alertmanager_paginated_silences_list"
+	GrafanaUnsilencePrefix            = "grafana_unsilence_"
+	AlertmanagerUnsilencePrefix       = "alertmanager_unsilence_"
+	GrafanaSilencePrefix              = "grafana_silence_"
+	AlertmanagerSilencePrefix         = "alertmanager_silence_"
+	GrafanaPrepareSilencePrefix       = "grafana_prepare_silence_"
+	AlertmanagerPrepareSilencePrefix  = "alertmanager_prepare_silence_"
 )

pkg/types/internal.go

@@ -59,5 +59,7 @@ type FiringAlertsListStruct struct {
 type SilencesListStruct struct {
 	Silences      []SilenceWithAlerts
 	ShowHeader    bool
+	Start         int
+	End           int
 	SilencesCount int
 }

pkg/types/silence_manager.go

@@ -13,6 +13,7 @@ type SilenceManager interface {
 	CreateSilence(silence Silence) (SilenceCreateResponse, error)
 	GetSilenceMatchingAlerts(silence Silence) ([]AlertmanagerAlert, error)
 	DeleteSilence(silenceID string) error
+	GetPaginatedSilencesListPrefix() string
 	GetSilencePrefix() string
 	GetUnsilencePrefix() string
 	Name() string

pkg/types/stub_silence_manager.go

@@ -84,6 +84,10 @@
 	return "stub_unsilence"
 }
 
+func (m *StubSilenceManager) GetPaginatedSilencesListPrefix() string {
+	return "stub_paginate_silences"
+}
+
 func (m *StubSilenceManager) Name() string {
 	return "StubSilenceManager"
 }

templates/silences_list.html

@@ -1,10 +1,8 @@
-{{- if .Data.ShowHeader }}
 {{- if not .Data.Silences }}
 <strong>Silences</strong>
 No silences.
 {{- else }}
-<strong>Silences ({{ .Data.SilencesCount }}):</strong>
-{{- end }}
+<strong>Silences ({{.Data.Start}} - {{ .Data.End }} of {{ .Data.SilencesCount }}):</strong>
 {{- end }}
 {{ range $silenceId, $silenceInfo := .Data.Silences }}
 <strong>ID:</strong> <code>{{ $silenceInfo.Silence.ID }}</code>